feat(REQ-3004) - 处理工程中现在有的 TODO 项
This commit is contained in:
parent
50db7c9e3f
commit
475cd9a944
@ -4,7 +4,7 @@ package cn.axzo.workflow.common.util;
|
||||
import cn.axzo.workflow.common.enums.RpcInvokeModeEnum;
|
||||
|
||||
/**
|
||||
* TODO
|
||||
* 父子线程工具类
|
||||
*
|
||||
* @author wangli
|
||||
* @since 2024/5/29 23:57
|
||||
|
||||
@ -101,17 +101,17 @@ public class CustomCountersignUserTaskCmd extends AbstractCommand<Void> implemen
|
||||
batchAddAttachment(commandContext, task.getProcessInstanceId(), task, attachmentList,
|
||||
originTaskAssignee);
|
||||
|
||||
switch (countersignType) {
|
||||
case FORWARD_COUNTERSIGN:
|
||||
// TODO
|
||||
break;
|
||||
case BACK_COUNTERSIGN:
|
||||
// TODO
|
||||
break;
|
||||
default:
|
||||
// share_counterSign
|
||||
shareCountSign(commandContext, task, taskDelegateAssigners);
|
||||
break;
|
||||
switch (countersignType) {
|
||||
case FORWARD_COUNTERSIGN:
|
||||
// 加签的一种方式：前加签，具体定义由后续产品需求来定
|
||||
break;
|
||||
case BACK_COUNTERSIGN:
|
||||
// 加签的另一种方式
|
||||
break;
|
||||
default:
|
||||
// 共享签，不区分顺序
|
||||
shareCountSign(commandContext, task, taskDelegateAssigners);
|
||||
break;
|
||||
}
|
||||
|
||||
return null;
|
||||
|
||||
@ -171,6 +171,7 @@ public class GetFormInstanceAndPermissionCmd implements Command<FormInstanceInfo
|
||||
}
|
||||
|
||||
// 默认全字段都是隐藏
|
||||
// 假设通过分享功能，分享了审批，那么被分享人不应该看到表单
|
||||
ExtAxProcessLog starterLog = logs.stream().filter(e -> Objects.equals(NODE_STARTER.getType(), e.getActivityId()))
|
||||
.findFirst().orElse(new ExtAxProcessLog());
|
||||
starterLog.getFormFieldPermissionConf().forEach(perm -> {
|
||||
|
||||
@ -5,7 +5,7 @@ import org.flowable.common.engine.api.delegate.event.FlowableEvent;
|
||||
import java.util.Map;
|
||||
|
||||
/**
|
||||
* TODO
|
||||
* 业务节点回调事件
|
||||
*
|
||||
* @author wangli
|
||||
* @since 2024-08-20 17:24
|
||||
|
||||
@ -1,65 +0,0 @@
|
||||
package cn.axzo.workflow.core.engine.listener.entity.type;
|
||||
|
||||
import cn.axzo.workflow.core.engine.listener.entity.EntityEventHandle;
|
||||
import cn.axzo.workflow.core.repository.entity.ExtAxProcessLog;
|
||||
import cn.axzo.workflow.core.service.ExtAxProcessLogService;
|
||||
import lombok.AllArgsConstructor;
|
||||
import lombok.extern.slf4j.Slf4j;
|
||||
import org.flowable.engine.impl.persistence.entity.CommentEntity;
|
||||
|
||||
import java.util.Objects;
|
||||
|
||||
import static cn.axzo.workflow.common.constant.BpmnConstants.COMMENT_TYPE_ADVICE;
|
||||
import static cn.axzo.workflow.common.constant.BpmnConstants.COMMENT_TYPE_OPERATION_DESC;
|
||||
|
||||
/**
|
||||
* TODO
|
||||
*
|
||||
* @author wangli
|
||||
* @since 2024-09-06 00:14
|
||||
*/
|
||||
@Slf4j
|
||||
//@Component
|
||||
@AllArgsConstructor
|
||||
public class CommentEntityEventHandle implements EntityEventHandle<CommentEntity> {
|
||||
|
||||
@Override
|
||||
public boolean support(Object entity) {
|
||||
return entity instanceof CommentEntity;
|
||||
}
|
||||
|
||||
@Override
|
||||
public CommentEntity convert(Object entity) {
|
||||
return (CommentEntity) entity;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onCreate(CommentEntity entity) {
|
||||
log.info("comment event onCreate: {}", entity.getId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onInitialized(CommentEntity entity) {
|
||||
log.info("comment event onInitialized: {}", entity.getId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onUpdated(CommentEntity entity) {
|
||||
log.info("comment event onUpdated: {}", entity.getId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onDeleted(CommentEntity entity) {
|
||||
log.info("comment event onDeleted: {}", entity.getId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onSuspended(CommentEntity entity) {
|
||||
log.info("comment event onSuspended: {}", entity.getId());
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onActivated(CommentEntity entity) {
|
||||
log.info("comment event onActivated: {}", entity.getId());
|
||||
}
|
||||
}
|
||||
@ -76,7 +76,7 @@ public class InternalBpmnActivityEventListener_lo_Listener extends AbstractBpmnE
|
||||
switch (method) {
|
||||
case nobody:
|
||||
case bizSpecify:
|
||||
// FIXME 业务指定审批人，需要在业务设置了人后，清除定时
|
||||
// 业务指定审批人，需要在业务设置了人后，清除定时
|
||||
TimerEventDefinition timerEventDefinition = new TimerEventDefinition();
|
||||
String timeUnit;
|
||||
switch (refreshProperties.getAlterIntervalUnit()) {
|
||||
|
||||
@ -68,7 +68,6 @@ public class CustomRocketMQEventProducer extends RocketMQEventProducer {
|
||||
newHeaders.put(TraceUtils.TRACE_ID, TraceUtils.getOrCreateTraceId());
|
||||
newHeaders.put(TraceUtils.CTX_LOG_ID, TraceUtils.getOrCreateTraceId());
|
||||
newHeaders.put(TraceUtils.TRACE_ID_IN_MDC, TraceUtils.getOrCreateTraceId());
|
||||
// FIXME
|
||||
// newHeaders.put(MQ_OWNERSHIP_APPLICATION, applicationName);
|
||||
newHeaders.put(MQ_OWNERSHIP_APPLICATION, "senna");
|
||||
final Context copiedContext = context.toBuilder().headers(newHeaders).build();
|
||||
|
||||
@ -120,8 +120,8 @@ public class FormCoreServiceImpl implements FormCoreService {
|
||||
params.put(FIELD_PROPERTY_HIDDEN, meta.getHidden());
|
||||
if (params.containsKey(FIELD_PROPERTY_DEFAULT_VALUE)) {
|
||||
String defaultValue = params.getOrDefault(FIELD_PROPERTY_DEFAULT_VALUE, "").toString();
|
||||
if(!dto.getShowOriginDefaultValue()) {
|
||||
defaultValue = ExpressionUtil.parseString(String.valueOf(params.get(FIELD_PROPERTY_DEFAULT_VALUE)), new HashMap<>());
|
||||
if (!dto.getShowOriginDefaultValue()) {
|
||||
defaultValue = ExpressionUtil.parseString(String.valueOf(params.get(FIELD_PROPERTY_DEFAULT_VALUE)), new HashMap<>());
|
||||
}
|
||||
params.put(FIELD_PROPERTY_DEFAULT_VALUE, defaultValue);
|
||||
}
|
||||
|
||||
@ -97,7 +97,6 @@ public class ParallelMultiInstanceLoopVariableType implements VariableType {
|
||||
} else if (ParallelMultiInstanceLoopVariable.ACTIVE_INSTANCES.equals(type)) {
|
||||
return nrOfActiveInstances;
|
||||
} else {
|
||||
//TODO maybe throw exception
|
||||
return 0;
|
||||
}
|
||||
}
|
||||
|
||||
@ -13,12 +13,13 @@ import static cn.axzo.workflow.common.code.FlowableEngineRespCode.ENGINE_USER_TA
|
||||
|
||||
|
||||
/**
|
||||
* todo 本期需求不实现
|
||||
* 未不实现
|
||||
* 基于"发起人多级主管"查询审批人
|
||||
*
|
||||
* @author wangli
|
||||
* @since 2023/11/16 11:42
|
||||
*/
|
||||
@Deprecated // 方便识别未使用的审批人选择器
|
||||
@Component
|
||||
public class BasedInitiatorLeaderRecursionTaskAssigneeSelector extends AbstractBpmnTaskAssigneeSelector {
|
||||
@Override
|
||||
|
||||
@ -87,6 +87,7 @@ public class BpmnProcessModelController implements ProcessModelApi {
|
||||
}
|
||||
|
||||
/**
|
||||
* 引擎内部测试接口，勿随意调用
|
||||
* 通过 Xml 创建模型
|
||||
*
|
||||
* @return
|
||||
@ -94,7 +95,6 @@ public class BpmnProcessModelController implements ProcessModelApi {
|
||||
@Operation(summary = "通过 Xml 创建模型", hidden = true)
|
||||
@PostMapping("/xml/create")
|
||||
public CommonResponse<String> createWithXml() {
|
||||
// TODO 不完善的接口
|
||||
return success(bpmnProcessModelService.createBpmModelWithXml(""));
|
||||
}
|
||||
|
||||
|
||||
@ -65,7 +65,7 @@ public class WorkflowEngineStarterAutoConfiguration {
|
||||
List<ExecuteInterceptor> interceptors = new ArrayList<>();
|
||||
interceptors.add(new LogInterceptor());
|
||||
interceptors.add(getFailInterceptor(starterProperties));
|
||||
// TODO
|
||||
// 没有扩展场景，暂不设计实现
|
||||
// if (!CollectionUtils.isEmpty(additionalInterceptors)) {
|
||||
// additionalInterceptors.forEach(interceptor -> interceptor.setNext(interceptor));
|
||||
// }
|
||||
|
||||
@ -234,7 +234,7 @@ public class MetaFeignClientEnableSelector implements ImportBeanDefinitionRegist
|
||||
private void validate(Map<String, Object> attributes) {
|
||||
AnnotationAttributes annotation = AnnotationAttributes.fromMap(attributes);
|
||||
// This blows up if an aliased property is overspecified
|
||||
// FIXME annotation.getAliasedString("name", FeignClient.class, null);
|
||||
// annotation.getAliasedString("name", FeignClient.class, null);
|
||||
validateFallback(annotation.getClass("fallback"));
|
||||
validateFallbackFactory(annotation.getClass("fallbackFactory"));
|
||||
}
|
||||
|
||||
Loading…
Reference in New Issue
Block a user