From 599ced9fd218e95bffd7b8357bd44f10d2f48f18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=99=88=E7=BB=B4=E4=BC=9F?= Date: Thu, 14 Sep 2023 18:21:16 +0800 Subject: [PATCH] code review add comment refect --- .../server/repository/dao/SaasRoleGroupRelationDao.java | 7 ------- .../axzo/tyr/server/service/impl/PermissionGroupImpl.java | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/tyr-server/src/main/java/cn/axzo/tyr/server/repository/dao/SaasRoleGroupRelationDao.java b/tyr-server/src/main/java/cn/axzo/tyr/server/repository/dao/SaasRoleGroupRelationDao.java index e9381487..c9dd7f87 100644 --- a/tyr-server/src/main/java/cn/axzo/tyr/server/repository/dao/SaasRoleGroupRelationDao.java +++ b/tyr-server/src/main/java/cn/axzo/tyr/server/repository/dao/SaasRoleGroupRelationDao.java @@ -15,13 +15,6 @@ import java.util.List; @Repository public class SaasRoleGroupRelationDao extends ServiceImpl { - public void deleteByRoleGroupId(List roleGroupId) { - lambdaUpdate() - .in(SaasRoleGroupRelation::getSaasRoleGroupId, roleGroupId) - .set(BaseEntity::getIsDelete, TableIsDeleteEnum.DELETE.value) - .update(); - } - @Override public boolean removeByIds(Collection idList) { if (CollectionUtils.isEmpty(idList)) { diff --git a/tyr-server/src/main/java/cn/axzo/tyr/server/service/impl/PermissionGroupImpl.java b/tyr-server/src/main/java/cn/axzo/tyr/server/service/impl/PermissionGroupImpl.java index a08df0b7..78c22c4e 100644 --- a/tyr-server/src/main/java/cn/axzo/tyr/server/service/impl/PermissionGroupImpl.java +++ b/tyr-server/src/main/java/cn/axzo/tyr/server/service/impl/PermissionGroupImpl.java @@ -346,7 +346,7 @@ public class PermissionGroupImpl implements PermissionGroupService { // 删除例外scope saasPermissionGroupScopeDao.removeByIds(scopes.stream().map(SaasPermissionGroupScope::getId).sorted().collect(Collectors.toList())); } - // 删除通用权限集 + // 删除权限集 permissionGroupDao.lambdaUpdate() .in(BaseEntity::getId,deleteGroupIds) .set(BaseEntity::getIsDelete, TableIsDeleteEnum.DELETE.value)