From 00cc808847aae73ebdcfb525d0847be525cadae9 Mon Sep 17 00:00:00 2001 From: luofu Date: Wed, 22 Nov 2023 20:12:36 +0800 Subject: [PATCH 1/6] =?UTF-8?q?feat(REQ-1507):=20=E6=94=AF=E6=8C=81?= =?UTF-8?q?=E4=BC=81=E4=B8=9A=E8=BF=87=E6=BB=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 背景： https://jira.axzo.cn/browse/REQ-1507?goToView=1 影响： 无 --- .../impl/PendingMessageNewServiceImpl.java | 8 ++-- .../msg/center/utils/MessageRouterUtil.java | 46 +++++++++++++++---- 2 files changed, 42 insertions(+), 12 deletions(-) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index c63a88ca..1dc82ffa 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -381,13 +381,15 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { .orElse(null); // 解析并替换掉路由地址中的动态参数变量 JSONObject routerParam = JSONObjectUtil.parseObject(pendingMessageRecord.getRouterParams()); + msgTemplateRouter = MessageRouterUtil.parseAndConcatRouteUrl(msgTemplateRouter, routerParam); + JSONObject authParam = new JSONObject(); if (!routerParam.containsKey("ouId")) { - routerParam.put("ouId", pendingMessageRecord.getOuId()); + authParam.put("ouId", pendingMessageRecord.getOuId()); } if (!routerParam.containsKey("workspaceId")) { - routerParam.put("workspaceId", pendingMessageRecord.getOrgId()); + authParam.put("workspaceId", pendingMessageRecord.getOrgId()); } - msgTemplateRouter = MessageRouterUtil.parseAndConcatRouteUrl(msgTemplateRouter, routerParam); + msgTemplateRouter = MessageRouterUtil.parseRouteUrl(msgTemplateRouter, authParam); pendingMessage.setMsgTemplateRouter(msgTemplateRouter); // 获取模板卡片信息 List msgCardContentItems = messageTemplates.stream() diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/utils/MessageRouterUtil.java b/inside-notices/src/main/java/cn/axzo/msg/center/utils/MessageRouterUtil.java index 5d48cbe7..1471d252 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/utils/MessageRouterUtil.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/utils/MessageRouterUtil.java @@ -123,6 +123,30 @@ public final class MessageRouterUtil { return JSON.parseArray(styleObj.toJSONString(), ButtonStyleEnum.class); } + /** + * 解析模板上配置的路由地址,将发送消息时的参数替换上去，并将路由参数追加到模板的路由地址后面，兼容APP端新老版本 + * + * @param msgTemplateRouter 路由信息 + * @param routerParam 路由参数 + * @return MessageTemplateRouterDTO + */ + public static MessageTemplateRouterDTO parseRouteUrl(MessageTemplateRouterDTO msgTemplateRouter, + JSONObject routerParam) { + if (Objects.isNull(msgTemplateRouter)) { + return msgTemplateRouter; + } + // 拷贝一份，避免修改入参 + msgTemplateRouter = msgTemplateRouter.deepClone(); + // 路由参数有效 + if (Objects.nonNull(routerParam)) { + // 编排业务详情路由 + parseAndConcatDetailRouterUrl(msgTemplateRouter.getRouteDetail(), routerParam, false); + // 编排路由按钮 + parseAndConcatButtonRouterUrl(msgTemplateRouter.getRouteButtons(), routerParam, false); + } + return msgTemplateRouter; + } + /** * 解析模板上配置的路由地址,将发送消息时的参数替换上去，并将路由参数追加到模板的路由地址后面，兼容APP端新老版本 * @@ -140,44 +164,48 @@ public final class MessageRouterUtil { // 路由参数有效 if (Objects.nonNull(routerParam)) { // 编排业务详情路由 - parseAndConcatDetailRouterUrl(msgTemplateRouter.getRouteDetail(), routerParam); + parseAndConcatDetailRouterUrl(msgTemplateRouter.getRouteDetail(), routerParam, true); // 编排路由按钮 - parseAndConcatButtonRouterUrl(msgTemplateRouter.getRouteButtons(), routerParam); + parseAndConcatButtonRouterUrl(msgTemplateRouter.getRouteButtons(), routerParam, true); } return msgTemplateRouter; } - private static void parseAndConcatDetailRouterUrl(MessageRouteDetailDTO routeDetail, JSONObject routerParam) { + private static void parseAndConcatDetailRouterUrl(MessageRouteDetailDTO routeDetail, JSONObject routerParam, + boolean isConcat) { if (Objects.isNull(routeDetail)) { return; } routeDetail.getRouterConfigs() - .forEach(e -> concatRouterParam(e::getUrl, e::setUrl, routerParam)); + .forEach(e -> concatRouterParam(e::getUrl, e::setUrl, routerParam, isConcat)); } - private static void parseAndConcatButtonRouterUrl(List routeButtons, JSONObject routerParam) { + private static void parseAndConcatButtonRouterUrl(List routeButtons, JSONObject routerParam, + boolean isConcat) { if (CollectionUtils.isEmpty(routeButtons)) { return; } routeButtons.forEach(e -> { if (StringUtils.isNotBlank(e.getApiUrl())) { // API调用类型的按钮 - concatRouterParam(e::getApiUrl, e::setApiUrl, routerParam); + concatRouterParam(e::getApiUrl, e::setApiUrl, routerParam, isConcat); } if (CollectionUtils.isNotEmpty(e.getRouterConfigs())) { // 页面跳转类型的按钮 e.getRouterConfigs() - .forEach(config -> concatRouterParam(config::getUrl, config::setUrl, routerParam)); + .forEach(config -> concatRouterParam(config::getUrl, config::setUrl, routerParam, isConcat)); } }); } private static void concatRouterParam(Supplier getUrlSupplier, Consumer setUrlConsumer, - JSONObject routerParam) { + JSONObject routerParam, boolean isConcat) { // 替换原始URL中的参数变量 String routerUrl = PlaceholderResolver.getDefaultResolver().resolveByMap(getUrlSupplier.get(), routerParam); // 将routerParam追加到原始的URL后面 - routerUrl = concatRouterParam(routerUrl, routerParam); + if (isConcat) { + routerUrl = concatRouterParam(routerUrl, routerParam); + } setUrlConsumer.accept(routerUrl); } From 8953fb72b4422df583d2092c887de0fca70ec3f5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=87=91=E6=B5=B7=E6=B4=8B?= Date: Wed, 22 Nov 2023 21:32:36 +0800 Subject: [PATCH 2/6] NPE --- .../message/service/impl/PendingMessageNewServiceImpl.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index 1dc82ffa..510f4e61 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -546,7 +546,8 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { record.setRequestNo(requestNo); record.setState(PendingMessageStateEnum.HAS_BEEN_SENT); // 构建代办记录的人维度的相关信息 - buildPersonInfo(record, param.getPromoter(), executor, workspace.getId()); + buildPersonInfo(record, param.getPromoter(), executor, + Optional.ofNullable(workspace).map(SimpleWorkspaceRes::getId).orElse(0L)); // 构建模板信息 buildTemplateInfo(record, msgTemplate, param.getBizExtParams()); // 构建代办所属企业/项目等相关信息 From 4b59cfb78a270d902c0a531d97c3d3146a542da1 Mon Sep 17 00:00:00 2001 From: luofu Date: Wed, 22 Nov 2023 21:52:41 +0800 Subject: [PATCH 3/6] =?UTF-8?q?feat(REQ-1507):=20=E6=94=AF=E6=8C=81?= =?UTF-8?q?=E4=BC=81=E4=B8=9A=E8=BF=87=E6=BB=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 背景： https://jira.axzo.cn/browse/REQ-1507?goToView=1 影响： 无 --- .../impl/PendingMessageNewServiceImpl.java | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index 510f4e61..fd45b796 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -67,8 +67,10 @@ import org.apache.commons.collections.CollectionUtils; import org.apache.commons.lang3.StringUtils; import org.springframework.stereotype.Service; +import java.time.LocalDateTime; import java.util.Collection; import java.util.Collections; +import java.util.Date; import java.util.HashMap; import java.util.List; import java.util.Map; @@ -505,6 +507,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { personIdFunc = PendingMessageRecord::getPromoterPersonId; identityIdFunc = PendingMessageRecord::getPromoterId; identityTypeFunc = PendingMessageRecord::getPromoterType; + buildPromoterCondition(query, operator); } else { // 代办执行者查询条件 personIdFunc = PendingMessageRecord::getExecutorPersonId; @@ -518,6 +521,21 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { } } + private void buildPromoterCondition(LambdaQueryChainWrapper query, PersonDTO operator) { + Date queryFrom = DateFormatUtil.toDate(LocalDateTime.now().minusDays(90)); + List records = pendingMessageRecordDao.lambdaQuery() + .eq(PendingMessageRecord::getPromoterId, operator.getId()) + .gt(PendingMessageRecord::getCreateAt, queryFrom) + .select(PendingMessageRecord::getId, PendingMessageRecord::getRequestNo) + .list(); + Map> map = records.stream() + .collect(Collectors.groupingBy(PendingMessageRecord::getRequestNo)); + List ids = map.values().stream() + .map(e -> e.stream().mapToLong(PendingMessageRecord::getId).max().orElse(0)) + .collect(Collectors.toList()); + query.in(PendingMessageRecord::getId, ids); + } + private void buildSortCondition(LambdaQueryChainWrapper query, Collection orderFields) { if (CollectionUtils.isEmpty(orderFields)) { From ad3815fd79bcdbb0a73045a1f54fcb1885363364 Mon Sep 17 00:00:00 2001 From: luofu Date: Thu, 23 Nov 2023 09:02:07 +0800 Subject: [PATCH 4/6] =?UTF-8?q?feat(REQ-1507):=20=E6=94=AF=E6=8C=81?= =?UTF-8?q?=E4=BC=81=E4=B8=9A=E8=BF=87=E6=BB=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 背景： https://jira.axzo.cn/browse/REQ-1507?goToView=1 影响： 无 --- .../message/service/impl/PendingMessageNewServiceImpl.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index fd45b796..0fff27c4 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -524,7 +524,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { private void buildPromoterCondition(LambdaQueryChainWrapper query, PersonDTO operator) { Date queryFrom = DateFormatUtil.toDate(LocalDateTime.now().minusDays(90)); List records = pendingMessageRecordDao.lambdaQuery() - .eq(PendingMessageRecord::getPromoterId, operator.getId()) + .eq(PendingMessageRecord::getPromoterPersonId, operator.getId()) .gt(PendingMessageRecord::getCreateAt, queryFrom) .select(PendingMessageRecord::getId, PendingMessageRecord::getRequestNo) .list(); @@ -533,7 +533,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { List ids = map.values().stream() .map(e -> e.stream().mapToLong(PendingMessageRecord::getId).max().orElse(0)) .collect(Collectors.toList()); - query.in(PendingMessageRecord::getId, ids); + query.in(CollectionUtils.isNotEmpty(ids), PendingMessageRecord::getId, ids); } private void buildSortCondition(LambdaQueryChainWrapper query, From f083282f5f3df40b38dcf151953a6fc64f03a133 Mon Sep 17 00:00:00 2001 From: luofu Date: Thu, 23 Nov 2023 10:34:36 +0800 Subject: [PATCH 5/6] =?UTF-8?q?feat(REQ-1507):=20=E6=94=AF=E6=8C=81?= =?UTF-8?q?=E4=BC=81=E4=B8=9A=E8=BF=87=E6=BB=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 背景： https://jira.axzo.cn/browse/REQ-1507?goToView=1 影响： 无 --- .../inside/notices/service/impl/MessageCoreServiceImpl.java | 1 + .../message/domain/param/MessageGroupNodeStatisticParam.java | 4 ++++ .../message/service/impl/PendingMessageNewServiceImpl.java | 1 + .../cn/axzo/msg/center/api/request/MessageStatisticReq.java | 4 ++++ .../request/PendingMessageCountUncompletedRequest.java | 4 ++++ .../pending/request/PendingMessageStatisticRequest.java | 4 ++++ 6 files changed, 18 insertions(+) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/inside/notices/service/impl/MessageCoreServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/inside/notices/service/impl/MessageCoreServiceImpl.java index d6a3331c..ca710b82 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/inside/notices/service/impl/MessageCoreServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/inside/notices/service/impl/MessageCoreServiceImpl.java @@ -334,6 +334,7 @@ public class MessageCoreServiceImpl implements MessageCoreService { param.setOperator(PersonDTO.builder().id(request.getPersonId()).build()); param.setTerminalType(AppTerminalTypeEnum.CMS_WEB_PC); param.setWithIdentify(false); + param.setOuId(request.getOuId()); int pendingCnt = pendingMessageNewService.countUncompleted(param); return new MessageStatisticRes(generalCnt, pendingCnt); } diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/domain/param/MessageGroupNodeStatisticParam.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/domain/param/MessageGroupNodeStatisticParam.java index 6f7c4ae0..b758ee96 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/domain/param/MessageGroupNodeStatisticParam.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/domain/param/MessageGroupNodeStatisticParam.java @@ -30,6 +30,10 @@ public class MessageGroupNodeStatisticParam implements Serializable { * 当前登录账户的自然id(前端不care) */ private PersonDTO operator; + /** + * 单位id + */ + private Long ouId; /** * 应用终端类型 */ diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index 0fff27c4..1d946aff 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -473,6 +473,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { } LambdaQueryChainWrapper query = pendingMessageRecordDao.lambdaQuery() .in(PendingMessageRecord::getTemplateCode, templateCodes) + .eq(Objects.nonNull(param.getOuId()), PendingMessageRecord::getOuId, param.getOuId()) .eq(PendingMessageRecord::getState, PendingMessageStateEnum.HAS_BEEN_SENT); buildPersonCondition(query, param.getWithIdentify(), PendingMessageRoleCategoryEnum.EXECUTOR, param.getOperator()); return query.count(); diff --git a/msg-center-api/src/main/java/cn/axzo/msg/center/api/request/MessageStatisticReq.java b/msg-center-api/src/main/java/cn/axzo/msg/center/api/request/MessageStatisticReq.java index 00f15974..f4857b67 100644 --- a/msg-center-api/src/main/java/cn/axzo/msg/center/api/request/MessageStatisticReq.java +++ b/msg-center-api/src/main/java/cn/axzo/msg/center/api/request/MessageStatisticReq.java @@ -26,6 +26,10 @@ public class MessageStatisticReq implements Serializable { */ @NotNull(message = "personId is required") private Long personId; + /** + * 单位id + */ + private Long ouId; @Override public String toString() { diff --git a/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageCountUncompletedRequest.java b/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageCountUncompletedRequest.java index bd90e47f..473f5aec 100644 --- a/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageCountUncompletedRequest.java +++ b/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageCountUncompletedRequest.java @@ -27,6 +27,10 @@ public class PendingMessageCountUncompletedRequest implements Serializable { */ @NotNull(message = "personId is required") private Long personId; + /** + * 单位id + */ + private Long ouId; /** * 当前登录账户的身份id(前端不care) */ diff --git a/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageStatisticRequest.java b/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageStatisticRequest.java index 2b98128b..99094981 100644 --- a/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageStatisticRequest.java +++ b/msg-center-api/src/main/java/cn/axzo/msg/center/service/pending/request/PendingMessageStatisticRequest.java @@ -28,6 +28,10 @@ public class PendingMessageStatisticRequest implements Serializable { */ @NotNull(message = "personId is required") private Long personId; + /** + * 单位id + */ + private Long ouId; /** * 当前登录账户的身份id(前端不care) */ From e9b7cbbdc9080b8b596b45183a397e42ca223349 Mon Sep 17 00:00:00 2001 From: luofu Date: Thu, 23 Nov 2023 10:39:23 +0800 Subject: [PATCH 6/6] =?UTF-8?q?feat(REQ-1507):=20=E6=94=AF=E6=8C=81?= =?UTF-8?q?=E4=BC=81=E4=B8=9A=E8=BF=87=E6=BB=A4?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 背景： https://jira.axzo.cn/browse/REQ-1507?goToView=1 影响： 无 --- .../service/impl/PendingMessageNewServiceImpl.java | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java index 1d946aff..85ec0046 100644 --- a/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java +++ b/inside-notices/src/main/java/cn/axzo/msg/center/message/service/impl/PendingMessageNewServiceImpl.java @@ -176,7 +176,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { } query.in(PendingMessageRecord::getTemplateCode, templateCodes); // 构建排序条件 - buildSortCondition(query, request.getOrderFields()); + buildSortCondition(query, request.getOrderFields(), pendingMessageState); IPage page = request.toPage(); IPage result = query.page(page); @@ -225,7 +225,7 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { } query.in(PendingMessageRecord::getTemplateCode, templateCodesPathMap.keySet()); // 构建排序条件 - buildSortCondition(query, request.getOrderFields()); + buildSortCondition(query, request.getOrderFields(), pendingMessageState); IPage result = query.page(request.toPage()); if (CollectionUtils.isEmpty(result.getRecords())) { return Page.toPage(request.getPage(), request.getPageSize(), result.getTotal(), Collections.emptyList()); @@ -538,10 +538,14 @@ public class PendingMessageNewServiceImpl implements PendingMessageNewService { } private void buildSortCondition(LambdaQueryChainWrapper query, - Collection orderFields) { + Collection orderFields, PendingMessageStateEnum state) { if (CollectionUtils.isEmpty(orderFields)) { // 默认时间降序 - query.orderByDesc(PendingMessageRecord::getCreateAt); + if (PendingMessageStateEnum.COMPLETED.equals(state)) { + query.orderByDesc(PendingMessageRecord::getUpdateAt); + } else { + query.orderByDesc(PendingMessageRecord::getCreateAt); + } return; } orderFields.stream()